new: use _graphs instead of nxadb_graphs
#66
Merged
+77
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMahanna
commented
Oct 18, 2024
Comment on lines
-107
to
+114
| For now, the collection is called 'nxadb_graphs'. | ||
| The default collection is called `_graphs`. However, if the | ||
| `DATABASE_GRAPH_COLLECTION` environment variable is specified, | ||
| then that collection will be used. This variable is useful when the | ||
| database user does not have permission to access the `_graphs` | ||
| system collection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scratches
nxadb_graphsin favour of the_graphssystem collection.We once spoke about using this, but stopped because we couldn't guarantee that the database user has access to
_graphs.This is still valid, but I am suggesting we simply parameterize the Graph Collection Name (and have it by default set to
_graphs), instead of polluting every user DB with annxadb_graphscollection.IMO this is much cleaner. We no longer need to manually delete a graph from
nxadb_graphsonce a Graph has been removed from_graphs, which was getting annoying.Functionality remains the same, we simply embed the Graph Properties of the
nxadb.Graphobject under a a field callednetworkxwithin the associated_graphdocument. UX does not change, user doesn't even need to know about thisnetworkxnested field.